One-dimensional semiconductor-metal heterostructures manifest improved charge separation capability, tunable band gap and increased surface area, and have been regarded as promising photocatalysts for solar-to-fuel conversion through water splitting. We herein review the synthetic strategies for the rational design and preparation of one-dimensional semiconductor-metal heterostructures with precise control in terms of size, shape, composition and function. Approaches that are capable of improving the photocatalytic performance of one-dimensional semiconductor-metal heterostructures have been proposed and analyzed The present work is expected to give the rational design of one-dimensional semiconductor-metal heterostructures and provide insights into accomplishing highly efficient photocatalysis based on such materials